Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example from help(plot.Dataset) seems incorrect #15

Closed
TimHesterberg opened this issue Jan 30, 2024 · 2 comments
Closed

Example from help(plot.Dataset) seems incorrect #15

TimHesterberg opened this issue Jan 30, 2024 · 2 comments

Comments

@TimHesterberg
Copy link

library(rpact)
library(help = rpact)
# Version:                       3.5.0.9228
?plot.Dataset

# The first example is:
dataExample <- getDataset(
    n1 = c(22, 11, 22, 11),
    n2 = c(22, 13, 22, 13),
    means1 = c(1, 1.1, 1, 1),
    means2 = c(1.4, 1.5, 3, 2.5),
    stDevs1 = c(1, 2, 2, 1.3),
    stDevs2 = c(1, 2, 2, 1.3)
)
if (require(ggplot2)) plot(dataExample, main = "Comparison of Means")

# That gives warning messages:
# Warning messages:
# 1: `guides(<scale> = FALSE)` is deprecated. Please use `guides(<scale> = "none")` instead. 
# 2: Removed 73 rows containing non-finite values (stat_boxplot). 
# 3: Removed 73 rows containing non-finite values (stat_summary). 
# 4: Removed 73 rows containing missing values (geom_point). 

# The plot is missing the treatment group at stages 2 and 4

# The second example, plotting rates, also gives the first warning message.
@fpahlke
Copy link
Contributor

fpahlke commented Jan 31, 2024

Many thanks, Tim, for figuring this out.
I will find a solution and let you know when it is available on GitHub.
Best,
Friedrich

fpahlke added a commit that referenced this issue Feb 9, 2024
* The fields `.parameterNames` and `.parameterFormatFunctions` were removed from all rpact result objects in favor of a more efficient solution
* Issues [15](#15), [16](#16), and [17](#17) fixed
@fpahlke
Copy link
Contributor

fpahlke commented Feb 9, 2024

Fixed in branch dev/3.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants