Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes #35

Closed
gwassmer opened this issue May 20, 2024 · 1 comment
Closed

Minor fixes #35

gwassmer opened this issue May 20, 2024 · 1 comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request

Comments

@gwassmer
Copy link
Collaborator

gwassmer commented May 20, 2024 •
edited
Loading

  1. getDesignGroupSequential(futilityBounds = c(0,0), bindingFutility = FALSE) |> plot()
    Plot legend displays bindingFutility = TRUE

  2. getSampleSizeRates(groups = 1, thetaH0 = 0.2, riskRatio = FALSE)
    getPowerRates(groups = 1, thetaH0 = 0.2, riskRatio = FALSE, maxNumberOfSubjects = 100)
    There should be a warning that riskRatio = FALSE will be ignored (correct for getSamplesizeMeans and getPowerMeans)

  3. getDesignGroupSequential() |> getSampleSizeSurvival() |> summary()
    Expected study duration duration should have the same format as Analysis time (change to 2 decimal places)

  4. design <- getDesignGroupSequential(typeOfDesign = "asOF")
    dataExample <- getDataset(cumEvents = c(67, 129), cumLogRanks = c(-1.1, -2.0))
    getAnalysisResults(design = design, dataInput = dataExample) |> summary()
    For group sequential design second line in summary should not "Fixed weight" but "Planned information rate",
    "Fixed weight" only for combination test"!

  5. Bug for pipe operator in analysis results:
    S <- getDataSet(
    events1 = c(11, 12),
    events2 = c(6, 7),
    n1 = c(36, 39),
    n2 = c(38, 40))
    R <- getDataSet(
    events1 = c(12, 10),
    events2 = c(8, 8),
    n1 = c(32, 33),
    n2 = c(31, 29))
    getDesignInverseNormal(kMax = 2) |> getDataSet(S1 = S, R = R) |>
    getAnalysisResults(stage = 1, nPlanned = 150, intersectionTest = "Simes" ) |> pull(conditionalPower)
fpahlke added a commit that referenced this issue May 27, 2024
@fpahlke
* Extension of the function getPerformanceScore() for sample size r…
8735fcd 
…ecalculation rules to the setting of binary endpoints according to [Bokelmann et al. (2024)](https://doi.org/10.1186/s12874-024-02150-4)

* The `getSimulationMultiArmMeans()`, `getSimulationMultiArmRates()`, and `getSimulationMultiArmSurvival()` functions now support an enhanced `selectArmsFunction` argument. Previously, only `effectVector` and `stage` were allowed as arguments. Now, users can optionally utilize additional arguments for more powerful custom function implementations, including `conditionalPower`, `conditionalCriticalValue`, `plannedSubjects/plannedEvents`, `allocationRatioPlanned`, `selectedArms`, `thetaH1` (for means and survival), `stDevH1` (for means), `overallEffects`, and for rates additionally: `piTreatmentsH1`, `piControlH1`, `overallRates`, and `overallRatesControl`.
* Same as below for`getSimulationEnrichmentMeans()`, `getSimulationEnrichmentRates()`, and `getSimulationEnrichmentSurvival()`. Specifically, support for population selection with `selectPopulationsFunction` argument based on predictive/posterior probabilities added (see [#32](#32))
* Issues [#25](#25), [#35](#35), and [#36](#36) fixed
* Minor improvements
@fpahlke fpahlke mentioned this issue May 28, 2024
Merged
@fpahlke
Copy link
Member

fpahlke commented May 28, 2024

Issues fixed in branch dev/4.0.0

Details:

  • 1, 3, 4, 5: solved.
  • 2: not yet implemented: Explanation for why this change cannot be implemented quickly: The default value for riskRatio is FALSE, and thetaH0 depends on a valid riskRatio value. Therefore, changing the default to NA is not straightforward, as NA is necessary to determine whether the value is user-defined or not.

@fpahlke fpahlke closed this as completed May 28, 2024
@fpahlke fpahlke added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fpahlke @gwassmer