Updated for Bacon2D API changes #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| sensor: true | ||
| onBeginContact: { | ||
| var body = other.getBody(); | ||
| if (body.target.glassContact === true) { |
There was a problem hiding this comment.
I'm not sure to understand this modify. So, we take the body with getBody(), and this makes sense, but what is it target? And why is a property of body?
There was a problem hiding this comment.
Since Body no longer inherits from QQuickItem, it now provides a property for target, which is the QQuickItem associated with the Body. In Bacon2D that is set to the Entity. It's very convenient in collisions, you don't have to hope other.parent is the Entity, you can rely on other.target.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to work with API changes in Bacon2D