Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code review / Testing changes #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Code review / Testing changes #30

wants to merge 2 commits into from

Conversation

jpmcmu
Copy link

@jpmcmu jpmcmu commented Jun 12, 2023

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).

Checklist:

  • I have created a corresponding JIRA ticket for this submission
  • My code follows the code style of this project.
    • I have applied the Eclipse code-format template provided.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the HPCC Systems CONTRIBUTORS document (https://github.com/hpcc-systems/HPCC-Platform/wiki/Guide-for-contributors).
  • The change has been fully tested:
    • This change does not cause any existing JUnits to fail.
    • I have include JUnit coverage to test this change
    • I have performed system test and covered possible regressions and side effects.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • This change fixes the problem, not just the symptom

Testing:

rpastrana and others added 2 commits June 8, 2023 16:36
@rpastrana
HPCC4J-334 Automate WsClient Interface
076a329 
- Adds python to generate new wsdls, stub, and wrappers
- Adds vscode launch profile

Signed-off-by: Rodrigo Pastrana <rodrigo.pastrana@lexisnexisrisk.com>
@jpmcmu
Code review / Testing changes
686c41c
@rpastrana rpastrana force-pushed the HPCC4J-334-Automate-WsClient-Interface branch from 1407fd8 to 75acd13 Compare June 12, 2023 14:22
@jpmcmu
Copy link
Author

jpmcmu commented Jun 12, 2023

@rpastrana I think I fixed the build output / success check, but it could use some more testing. To run the task: CMD Shift + P -> Run Task -> WSDL Generation.

@rpastrana rpastrana force-pushed the HPCC4J-334-Automate-WsClient-Interface branch 6 times, most recently from 52d6feb to 9768e2c Compare June 16, 2023 19:28
@rpastrana rpastrana closed this Feb 13, 2024
@rpastrana rpastrana reopened this Feb 13, 2024
@rpastrana rpastrana changed the base branch from HPCC4J-334-Automate-WsClient-Interface to master February 13, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jpmcmu @rpastrana