Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

FindCppcheck fails with cppcheck 1.5.3 #10

Closed
bdellegrazie opened this Issue · 5 comments

5 participants

@bdellegrazie

Hi,

I'm using your cmake-modules to apply cppcheck to our sources (thanks!), however I found a small issue when using cppcheck version 1.5.3.

In cppcheck version 1.5.3, the unused functions test is enabled with: --enable=unusedFunction, however in your Findcppcheck.cmake module you have this as:
--enable=unusedFunctions
(note the additional 's').

I'm not sure what the earlier behaviour was but the current version does not work.
Since this is a trivial fix I haven't created a pull request, but I'll try putting a diff in an additional comment.

Thanks,
Brett

@bdellegrazie
diff --git a/Findcppcheck.cmake b/Findcppcheck.cmake
index 02d351b..cf81cd1 100644
-- a/Findcppcheck.cmake
++ b/Findcppcheck.cmake
@@ -103,7 +103,7 @@ if(CPPCHECK_EXECUTABLE)
    if("${CPPCHECK_STYLE_ARG}" STREQUAL "--enable=style")

        _cppcheck_set_arg_var(CPPCHECK_UNUSEDFUNC_ARG
-           "--enable=unusedFunctions")
+           "--enable=unusedFunction")
        _cppcheck_set_arg_var(CPPCHECK_INFORMATION_ARG "--enable=information")
        _cppcheck_set_arg_var(CPPCHECK_MISSINGINCLUDE_ARG
            "--enable=missingInclude")
@jklontz

I experienced the same problem running cppcheck version 1.49. The above patch fixed it for me. Thanks!

@Micket

Thanks. I should have checked here before starting to debug myself. I too can confirm that the patch fixes 1.5.7.

@nmikhailov

Year later, still not fixed. Above patch fixes 1.59 too.

@rpavlik
Owner

Would have been easier to not lose had it been a pull request, sorry. Looks like it got fixed.

@rpavlik rpavlik closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.