Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mv client.rs into rust dir #62

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

shuimuliang
Copy link
Contributor

i think the best practice is:
a Cargo.toml inlcude just [workspace]
libsolana_geyser_grpc in 'cargo new lib-geyser-grpc'
client in 'cargo new rust-client' or 'cargo new rust-client'

finally the dir is

[workspace]

members = [
    "lib-geyser-grpc",
    "rust-client",
]

/Cargo.toml
/lib-geyser-grpc/Cargo.toml
/lib-geyser-grpc/src/
/rust-client/Cargo.toml
/rust-client/src/client.rs

i think the best practice is:
a Cargo.toml inlcude just [workspace]
libsolana_geyser_grpc in 'cargo new lib_geyser_grpc'
client in 'cargo new client'

finally the dir is
/Cargo.toml
/lib_geyser_grpc/Cargo.toml
/lib_geyser_grpc/src/
/client/Cargo.toml
/client/src/client.rs
@shuimuliang shuimuliang linked an issue Feb 22, 2023 that may be closed by this pull request
* Moved to submodules

* Moved config-check binary path
@linuskendall linuskendall merged commit dfcf417 into master Feb 22, 2023
@fanatid fanatid deleted the 59-move-rust-code-into-solana-geyser-grpcrust branch February 22, 2023 15:23
@fanatid
Copy link
Collaborator

fanatid commented Feb 22, 2023

Thank you that re-organizing the project, it's good to have the client as "separate" project because it's clear how gRPC can be used without looking back to the plugin code. I think it would be better to have directory examples with js/ts/golang/rust but we can make it in the future if some other directory changes will be introduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move rust code into solana-geyser-grpc/rust
3 participants