Implement sys_time_get_timezone syscall #10197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
reviewed
Apr 26, 2021
Nekotekina
force-pushed
the
fxo
branch
2 times, most recently
from
21bf1f7
to
fe08908
Compare
|
Fixes incorrect hour in God of War savedata (UTC +02:00 CEST): Before: After: |
|
Fixed summertime (looks like it's supplied in minutes), please retest. |
Megamouse
reviewed
Apr 27, 2021
| case TIME_ZONE_ID_STANDARD: | ||
| { | ||
| *timezone = -tz.Bias; | ||
| *summertime = -tz.StandardBias; |
There was a problem hiding this comment.
I don't really understand the standard bias. But I'd assume that it should be added to the bias and not counted as summertime.
There was a problem hiding this comment.
I am relatively certain that the Standardbias doesn't count as summertime.
It's basically an addendum to the regular bias and is rarely used.
So it should be added to the bias in order to get a proper end result.
"This value is added to the value of the Bias member to form the bias used during standard time. In most time zones, the value of this member is zero."
Try to get system timezone automatically. Attempt to address RPCS3#10195.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to get system timezone automatically.
Used to be hardcoded to GMT+3.
Attempt to address #10195.