Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD: Refactor asmjit submodule #10230

Merged
merged 3 commits into from May 2, 2021

Conversation

p01arst0rm
Copy link
Contributor

moved asmjit submodule into its own directory structure

@p01arst0rm p01arst0rm changed the title Refactor asmjit submodule BUILD: Refactor asmjit submodule May 2, 2021
@p01arst0rm
Copy link
Contributor Author

cc @hcorion

@hcorion
Copy link
Member

hcorion commented May 2, 2021

For your other reorganization PRs the submodule is in a src folder, any particular reason you didn't do the same here?

@p01arst0rm
Copy link
Contributor Author

For your other reorganization PRs the submodule is in a src folder, any particular reason you didn't do the same here?

no reason, i just thought asmjit was an edge case hence it not being in the 3rdparty to begin with.

though im not sure which is cleaner. the non-submodule ones use a src folder, so i renamed the submodule to align;- however that can lead to weirdness with some analysis tools where all the submodules are labeled "src" instead of the actual submodule name.

im not sure if i should go back and change the submodules to the name of the repository, or use src. You're right though, they should follow a standard pattern

@hcorion
Copy link
Member

hcorion commented May 2, 2021

Yeah, the path asmjit/asmjit or libusb/libusb etc. is a bit weird, but having a submodule named src is definitely non-conventional and probably more weird. Let's do name/name instead of name/src

@p01arst0rm
Copy link
Contributor Author

okay, ill PR in a bit with a fix for that :)

@Megamouse Megamouse added the Build and CI Anything related to the build process and continuous integration label May 2, 2021
@Megamouse Megamouse merged commit df39bac into RPCS3:master May 2, 2021
@p01arst0rm p01arst0rm deleted the refactor-asmjit-submodule branch May 2, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build and CI Anything related to the build process and continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants