lv2: Fix overflows of periodic timers #10287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on saving the state of lv2 timers, I've noticed a bug can cause infinite events to be sent by timer thread. In the case of expire + period result overflowing such as if period was set to UINT64_MAX.
This is not an issue on real PS3 as I tested in https://github.com/elad335/myps3tests/tree/master/ppu_tests/timer%20overflow%20attempt
I've used explicit overflow checks because it's simpler to manage for an absolute periodic timer.
Moved ETIMEDOUT error check to its proper position.