Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD: Refactor glslang submodule #10361

Merged
merged 6 commits into from May 29, 2021

Conversation

p01arst0rm
Copy link
Contributor

combined glslang-build and glslang into a single
directory structure, and moved them to 3rdparty/

@p01arst0rm p01arst0rm changed the title Refactor glslang submodule BUILD: Refactor glslang submodule May 28, 2021
@p01arst0rm
Copy link
Contributor Author

cc @hcorion

@MSuih MSuih requested a review from hcorion May 28, 2021 06:28
@MSuih MSuih added the Build and CI Anything related to the build process and continuous integration label May 28, 2021
@hcorion
Copy link
Member

hcorion commented May 28, 2021

If we're going to move glslang it should be consistent with the other libraries in 3rdparty and be glslang/glslang, instead of having a glslang-build folder

@p01arst0rm
Copy link
Contributor Author

sure :)

Copy link
Member

@hcorion hcorion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 from the CMake side

@Nekotekina Nekotekina merged commit 7c7cc39 into RPCS3:master May 29, 2021
@p01arst0rm p01arst0rm deleted the refactor-glslang-submodule branch May 29, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build and CI Anything related to the build process and continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants