vk: Restructure renderpass management to accomodate input attachments #10382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Completely removes the feedback loop and replaces with hardware channel masking
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input attachments are the preferred way to sample a framebuffer in a feedback loop and are the only technique allowed by the spec. This PR adds support for input attachments. While initially used for attachment clears as a proof that it works, that pass has also been rewritten in the second commit to remove all reads. This should improve performance while also complying with spec.
With this PR I see no validation errors when SRM is enabled in most games and a lot of random crashing is gone when combined with the previous PR that also cleaned up a lot of UB code.