Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cereal submodule with a custom serialization utility #10391

Merged
merged 1 commit into from Jun 7, 2021

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Jun 1, 2021

  • Replaced cereal with c++20 custom alternative.
  • Fix RSX capture versioning checks.

@elad335 elad335 force-pushed the rm-cereal branch 3 times, most recently from ba4c135 to 5625b4d Compare June 1, 2021 16:56
@elad335 elad335 force-pushed the rm-cereal branch 7 times, most recently from d345823 to d6273f7 Compare June 1, 2021 19:10
@elad335 elad335 changed the title [TESTERS NEEDED] Remove cereal submodule Remove cereal submodule Jun 1, 2021
@elad335 elad335 force-pushed the rm-cereal branch 5 times, most recently from f3c0525 to fe09adf Compare June 1, 2021 20:13
@elad335 elad335 force-pushed the rm-cereal branch 4 times, most recently from 0eae407 to 5cd61fb Compare June 2, 2021 00:39
rpcs3/rpcs3.vcxproj Outdated Show resolved Hide resolved
@Nekotekina
Copy link
Member

The idea of "cracking down" all std containers and possible some custom ones into few categories based on concepts is pretty powerful, although reckless as of now and needs a lot of refining of concept usage.

@elad335 elad335 force-pushed the rm-cereal branch 4 times, most recently from 7592ca3 to c7d7afa Compare June 3, 2021 19:27
@elad335 elad335 force-pushed the rm-cereal branch 11 times, most recently from c785548 to c61170a Compare June 4, 2021 06:59
@Megamouse Megamouse added Bugfix Savestates Anything that involves savestates labels Jun 4, 2021
@Nekotekina
Copy link
Member

Nekotekina commented Jun 7, 2021

Rebased and made few changes, notably removed explicit bool operator since it conflicts with deserialization operator template.

rpcs3/util/serialization.hpp Outdated Show resolved Hide resolved
rpcs3/util/serialization.hpp Outdated Show resolved Hide resolved
rpcs3/util/serialization.hpp Outdated Show resolved Hide resolved
Bump RSX capture version, use new serializer.
@Nekotekina Nekotekina merged commit 2169e8d into RPCS3:master Jun 7, 2021
@elad335 elad335 changed the title Remove cereal submodule Replace cereal submodule with a custom serialization utility Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Savestates Anything that involves savestates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants