New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace cereal submodule with a custom serialization utility #10391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elad335
commented
Jun 1, 2021
•
edited
edited
- Replaced cereal with c++20 custom alternative.
- Fix RSX capture versioning checks.
elad335
force-pushed
the
rm-cereal
branch
3 times, most recently
from
June 1, 2021 16:56
ba4c135
to
5625b4d
Compare
Megamouse
reviewed
Jun 1, 2021
Megamouse
reviewed
Jun 1, 2021
elad335
force-pushed
the
rm-cereal
branch
7 times, most recently
from
June 1, 2021 19:10
d345823
to
d6273f7
Compare
elad335
changed the title
[TESTERS NEEDED] Remove cereal submodule
Remove cereal submodule
Jun 1, 2021
elad335
force-pushed
the
rm-cereal
branch
5 times, most recently
from
June 1, 2021 20:13
f3c0525
to
fe09adf
Compare
Megamouse
reviewed
Jun 1, 2021
Megamouse
reviewed
Jun 1, 2021
elad335
force-pushed
the
rm-cereal
branch
4 times, most recently
from
June 2, 2021 00:39
0eae407
to
5cd61fb
Compare
Megamouse
reviewed
Jun 2, 2021
The idea of "cracking down" all std containers and possible some custom ones into few categories based on concepts is pretty powerful, although reckless as of now and needs a lot of refining of concept usage. |
elad335
force-pushed
the
rm-cereal
branch
4 times, most recently
from
June 3, 2021 19:27
7592ca3
to
c7d7afa
Compare
elad335
force-pushed
the
rm-cereal
branch
11 times, most recently
from
June 4, 2021 06:59
c785548
to
c61170a
Compare
Rebased and made few changes, notably removed explicit bool operator since it conflicts with deserialization operator template. |
elad335
commented
Jun 7, 2021
elad335
commented
Jun 7, 2021
elad335
commented
Jun 7, 2021
Bump RSX capture version, use new serializer.
elad335
changed the title
Remove cereal submodule
Replace cereal submodule with a custom serialization utility
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.