rsx: Fix emulation stopping when at semaphore_acquire #10475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VelocityRa
pushed a commit
to VelocityRa/rpcs3
that referenced
this pull request
Jul 6, 2021
Ignore pause flags if thread is stopped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This indirectly fixes GOW Ascension after emulation (or RSX) was paused then stopped when RSX was executing semaphore_acquire. See
rpcs3/rpcs3/Emu/RSX/rsx_methods.cpp
Line 91 in c3415bc
Semantics of pause test should match Emu.IsPaused() which evaluates to false after emulation was stopped because pause flags lose their meaning in that situation.