Trophy notification improvements #10482
Conversation
…ion the same as the original PS3 trophy notification.
| { | ||
| if (!sliding_animation.active) | ||
| { | ||
| sliding_animation.end = { -f32(frame.w), 0, 0 }; | ||
| sliding_animation.end = { -f32(frame.w*1.25), 0, 0 }; |
There was a problem hiding this comment.
I suppose you want to speed up the leaving animation?
Anyway. it's missing some spaces
| sliding_animation.end = { -f32(frame.w*1.25), 0, 0 }; | |
| sliding_animation.end = { -f32(frame.w * 1.25f), 0, 0 }; |
There was a problem hiding this comment.
This fixes the notification not fully sliding back.
There was a problem hiding this comment.
I think the animation is broken because you moved the notification position to the right.
It's probably better to use that instead of some arbitrary factor
There was a problem hiding this comment.
I sent a commit without this part. Also fixed the formatting. It's ready to merge.
| u16 margin_sz = 9; | ||
| frame.w = 72 + text_view.w + margin_sz; |
There was a problem hiding this comment.
why are these values suddenly hardcoded?
the logic behind it should not change.
There was a problem hiding this comment.
Because this logic generates a giant right margin. I could make new logic if padding worked as it should, but it doesn't.
The best i can do is leave the first line like this and replace the second line with:
frame.w = margin_sz * 3 + image.w + text_view.w;
There was a problem hiding this comment.
That doesn't make sense. It never created a giant right margin before, so why should it now?
|
Please don't change the other lines of code that you didn't really touch. Somehow your last commit added a lot of format changes. |
| @@ -133,11 +135,11 @@ namespace rsx | |||
| text_view.auto_resize(); | |||
|
|
|||
| // Resize background to cover the text | |||
| u16 margin_sz = text_view.x - image.w - image.x; | |||
| frame.w = text_view.x + text_view.w + margin_sz; | |||
| u16 margin_sz = 9; | |||
There was a problem hiding this comment.
I think using this margin is fine. But it should probably be used to calculate the image position etc as well for consistency
There was a problem hiding this comment.
Note: Removal of auto resize means lots of testing specifically with different languages that dont use latin fonts. This will be needed with and without fw and also on linux and BSD. This hardcoded stuff to me just seems to be whats appealing in specific conditions. We had ugly overflowing text when using some system languages before.
There was a problem hiding this comment.
Tested Portuguese, English US, Japanese, Traditional Chinese, Korean, Russian and Danish. 18 different trophies each test. The only problem I noticed is that the first line remains in English, but this already happens in the current build so it isn't my fault. I can't test on linux and BSD.
…nd in the animation.
* Makes the text more similar to the original PS3 trophy notification.
Same trophy notification, but better. The notification is no longer squished in the corner and readability has been improved a lot.
Size, color, transparency, spacing, position and duration are now the same as the original PS3 trophy notification.
What is still missing:
Comparison:
After / Original
Before
Rpcs3.Repositories.2021.06.21.-.07.02.57.37.mp4