Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSVC] glslang fix + vs2022 fixes #10552

Merged
merged 2 commits into from Jul 17, 2021
Merged

[MSVC] glslang fix + vs2022 fixes #10552

merged 2 commits into from Jul 17, 2021

Conversation

ZeeWanderer
Copy link
Contributor

@ZeeWanderer ZeeWanderer commented Jul 15, 2021

  • glslang - fixed wrong path to common props
  • emucore - fixed for VS2022, it's a 64-bit app now
  • common_default.props - use C++20 standard for VS2022 and further

git-version-gen.cmd seems to work correctly with both 32/64-bit cmd so there should be no reason to force 64 bits unless i missed something.

Please verify common_default.props work under VS2019, due to some installer issues because of VS2022 preview i had to uninstall all other versions.

 - glslang - fixed wrong path to common props
 - emucore - fixed for VS2022, its a 64 bit app now
 - common_default.props - use C++20 standard for VS2022 and further
@Megamouse Megamouse added Build and CI Anything related to the build process and continuous integration OS: Windows labels Jul 15, 2021
@Megamouse
Copy link
Contributor

Megamouse commented Jul 16, 2021

Does it build on azure?

@ZeeWanderer
Copy link
Contributor Author

@Megamouse well, yes.
image

@Megamouse Megamouse merged commit 6250e47 into RPCS3:master Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build and CI Anything related to the build process and continuous integration OS: Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants