cellSaveData/UNIX: Optimize IO #10574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
added
Optimization
|
The full fs sync isn't even that slow, removing the fsync(fd) that is done per-file on the unix path solves the issue even with the fs-wide fsync still in place (https://github.com/RPCS3/rpcs3/pull/10574/files#diff-598e1ef261ba2582ce3ca55f76d9613dd8e6cf40acb3d53b4f91ee83cb156d0eR1956). I don't see why we even needed both to begin with in this specific scenario. |
|
Seems like it should be the solution then. |
|
What about simply removing the sync here: https://github.com/RPCS3/rpcs3/blob/master/Utilities/File.cpp#L2014 |
|
That would keep the pending_file usage and abstract away the OS-specific crap from cellSaveData in this instance. |
|
It has usage in other places. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #10573, please test.