Mark "Disabling Logging" message, make it explanatory #10784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
changed the title
Megamouse
reviewed
Aug 28, 2021
rpcs3/Emu/system_utils.cpp
Outdated
| @@ -37,7 +37,7 @@ namespace rpcs3::utils | |||
| { | |||
| if (!was_silenced) | |||
| { | |||
| sys_log.notice("Disabling logging..."); | |||
| sys_log.success("Disabling logging! This mode is not compatible with issue creations and help requests on forums."); | |||
There was a problem hiding this comment.
Suggested change
| sys_log.success("Disabling logging! This mode is not compatible with issue creations and help requests on forums."); | |
| sys_log.success("Logging disabled! Do not create issues on GitHub or on the forums while logging is disabled."); |
elad335
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now uses success log level, with the new description "Disabling logging! Do not create issues on GitHub or on the forums while logging is disabled."