overlays: Show feedback while stopping ppu compilation #10822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I actually had this idea for a while now and it kept nagging at me.
We currently just hide the game window whenever we stop emulation.
During PPU compilation this means that the window will seemingly close,
but the emulator won't be usable until all threads are finished compiling.
Since this isn't transparent to the user at all, I added a small workaround
that notifies the progress dialog that we are about to stop emulation.
This gives the dialog enough time to display a final message.
At the same time the game window isn't being hidden anymore in case that there is a progress dialog.