Do not allow to unpause after fatal error occured in emulation #10833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You could also take a look at the Emu.Pause issue i made recently |
MSuih
reviewed
Sep 7, 2021
|
@Megamouse Done. |
Megamouse
reviewed
Sep 7, 2021
|
I think you can just remove the bool return because we do not use it anywhere |
Megamouse
reviewed
Sep 7, 2021
|
btw, you can't use my commit. it doesn't work |
Megamouse
reviewed
Sep 7, 2021
|
It's needed because this function can be called from any thread, thus the return value tells whether or not the current thread is the one which paused so it can resume later. A bit like a mutex.try_lock() operation. |
Megamouse
reviewed
Sep 8, 2021
|
Lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a "frozen" paused state which cannot be resumed from, used with fatal errors and special executables loading modes. Previously the user could resume emulation after a fatal error occured, but it used to be a top secret flaw only developer knew. After #10830 it became less of a secret...