vk: Fix scanning for upload heap types. #10912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
requested changes
Sep 22, 2021
Megamouse
approved these changes
Sep 22, 2021
- HOST_CACHED support must be prioritized, but is not a mandate. - Scan for that flag explicitly and fall back to uncached if it is not supported. - Uncached memory is too slow for our requirements to contend with cached memory.
|
Thanks for quick fix ! :) I thought PR#10900 will eat 50% of speed forever, due to new functions implementation... But hopefully there was just a small bug =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10910