Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vk: Clean up around vkQueueSubmit handling #10942

Merged
merged 1 commit into from Sep 28, 2021

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Sep 28, 2021

  • Explicitly declare one version for CB flush and the other for Async flush
  • Always flush descriptors on CB flush in case of page fault handling.
    Other threads other than offloader can also enter the method and require normal flow.
  • Fix overlapping interrupt IDs.
  • Minor formatting fixes

Fixes rare flickering or flushing when WCB is enabled with the previous optimizations active. Also improves driver stability in theory.

- Explicitly declare one version for CB flush and the other for Async flush
- Always flush descriptors on CB flush in case of page fault handling.
  Other threads other than offloader can also enter the method and require normal flow.
- Fix overlapping interrupt IDs.
- Minor formatting fixes
@DefaltBR DefaltBR mentioned this pull request Sep 28, 2021
@kd-11 kd-11 merged commit dc8fc9f into RPCS3:master Sep 28, 2021
@Linear524
Copy link

Thanks !
This PR fixes crazy artifacts flickering in Journey after #10938 was merged to master branch :)

@Augusto7743
Copy link

In recent versions is using much less VRAM than versions before from that optimizations.
Have games using only less of 200 MB VRAM even enabling all default settings.
THANKS !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants