Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx: add boost mode shortcut #11357

Merged
merged 1 commit into from Feb 20, 2022
Merged

rsx: add boost mode shortcut #11357

merged 1 commit into from Feb 20, 2022

Conversation

Megamouse
Copy link
Contributor

I've had this lying around for ages but never added it because I wanted to implement the shortcut manager first (which never happened).
So I'll just make a draft and see what happens.

@Megamouse Megamouse marked this pull request as draft January 11, 2022 08:41
@MSuih
Copy link
Member

MSuih commented Jan 11, 2022

Should this also affect vblank? It's very limited if it only affect games that have unlimited fps.

@kd-11
Copy link
Contributor

kd-11 commented Jan 11, 2022

Should this also affect vblank? It's very limited if it only affect games that have unlimited fps.

That would need another set of hotkeys.

Copy link
Contributor

@kd-11 kd-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code itself is fine, but the shortcut isn't.
Ctrl+O is a shortcut for the verb "Open" and opens a file dialog in other applications. Can we use something better?

@Megamouse
Copy link
Contributor Author

It's 0 not O.
And yes. The shortcut is the only reason why it wasn't merged yet, because I am waiting for better suggestions

@kd-11
Copy link
Contributor

kd-11 commented Feb 13, 2022

Can we use function keys? Like Ctrl+F10 or something (macos can have different shortcuts)

@Megamouse Megamouse marked this pull request as ready for review February 20, 2022 10:32
@Megamouse Megamouse merged commit 93e7988 into RPCS3:master Feb 20, 2022
@Megamouse Megamouse deleted the boost branch February 20, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants