WolfSSL: Use a custom UTF-8 aware _stat on Windows #11378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CookiePLMonster
force-pushed
the
utf8-stat
branch
from
bfa1d2e
to
4dbbb8b
Compare
|
Dependant PR has been merged, so this is ready for review. Because of some recent changes to WolfSSL I had to add |
Megamouse
reviewed
Mar 20, 2022
CookiePLMonster
force-pushed
the
utf8-stat
branch
2 times, most recently
from
d07ec5d
to
59ff6fa
Compare
|
Hmm, rebase? |
CookiePLMonster
force-pushed
the
utf8-stat
branch
from
59ff6fa
to
c559761
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #11359 that was not possible to do until a change in WolfSSL. Must be rebased and merged after wolfSSL/wolfssl#4757 is in.
At the moment we don't use anything in WolfSSL that uses
XSTATbut this may not always be the case - so if it ever happens, the code will be ready and UTF-8 aware.