Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CallAfter to CallFromMainThread #11415

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Rename CallAfter to CallFromMainThread #11415

merged 1 commit into from
Feb 7, 2022

Conversation

Megamouse
Copy link
Contributor

No description provided.

@Megamouse Megamouse added the Refactoring Refactors or simplifies existing code label Jan 20, 2022
@elad335
Copy link
Contributor

elad335 commented Jan 20, 2022

What about AssignToMainThread ?

@Nekotekina
Copy link
Member

Nekotekina commented Jan 20, 2022 •
edited

SendFunctionObjectToMainThreadEventQueueWithoutWaitingForCompletionAndTrackEmulationStatePredicate

@Nekotekina
Copy link
Member

I mean who cares. It was an idiom in wxWidgets code.

@Megamouse
Copy link
Contributor Author

I think my choice of words conveys the intention while still keeping some resemblance to the old name

@Megamouse
Copy link
Contributor Author

I would like to wait with this until after the exit PR.
It would mess up my current review status

@Megamouse
Copy link
Contributor Author

I'll merge if there are no objections

@Megamouse Megamouse merged commit d172b9a into RPCS3:master Feb 7, 2022
@Megamouse Megamouse deleted the mainloop branch February 10, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Refactoring Refactors or simplifies existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Megamouse @elad335 @Nekotekina