Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys_game_board_storage_read(): Add more known code & Improve byte casting #12706

Merged
merged 1 commit into from Sep 26, 2022
Merged

sys_game_board_storage_read(): Add more known code & Improve byte casting #12706

merged 1 commit into from Sep 26, 2022

Conversation

brian218
Copy link
Contributor

@brian218 brian218 commented Sep 26, 2022

Added one more known code (0xC0), whose expected data is exactly the same as 0xF0's.
Also improved the conversion from u64[2] to u8[16];

@Nekotekina
Copy link
Member

memcpy is honestly fine, I'm pretty sure that casting to u8[16] is UB (should cast to u8* instead)

@brian218
Copy link
Contributor Author

memcpy is honestly fine, I'm pretty sure that casting to u8[16] is UB (should cast to u8* instead)

@Nekotekina Would reinterpret_cast<u8*>(psid) be better?

@Nekotekina
Copy link
Member

Okay.

@AniLeo AniLeo merged commit c996be3 into RPCS3:master Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants