SPU: Inline and batch MFC list transfers #12763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
force-pushed
the
mfc-list
branch
2 times, most recently
from
51dc9ad
to
8c85bb3
Compare
kd-11
reviewed
Oct 7, 2022
There was a problem hiding this comment.
My suggestion here is to move the method to its own file to try and keep SPUThread.cpp navigable (not that its in good shape even now). The inlining just makes the function way too large. Create a SPUListTransfer.cpp or something and move it there. This whole file needs some refactoring for the large meta-functions.
Nekotekina
reviewed
Oct 8, 2022
rpcs3/Emu/Cell/SPUThread.cpp
Outdated
| constexpr usz _128 = 128; | ||
|
|
||
| // Force constexpr std::max | ||
| #define mov_t(type, index, _ea) { const usz ea = _ea; *reinterpret_cast<type*>(dst + index * std::integral_constant<u64, std::max<u64>(sizeof(type), sizeof(v128))>::value + (ea & 0xf)) = *reinterpret_cast<const type*>(src + ea); } void() |
Nekotekina
reviewed
Oct 8, 2022
|
|
||
| u64 addr = begin; | ||
|
|
||
| // Optimization: if range_locked is not used, the addr check will always pass |
There was a problem hiding this comment.
The complete check is now in the function so register limit won't be reached, most of the time it's unlocked so the initial check suffices. I've optimized the underlying function for it.
|
Enabled fully the optimization for Atomic RSX FIFO which makes the perf boost more significant yet stability hasn't been sacrificed. |
elad335
force-pushed
the
mfc-list
branch
6 times, most recently
from
166c905
to
b1ae277
Compare
Bad conditions led to optimization misses and long-generated code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces overall CPU profiling load of this function from 9.6% to 6.8% and grants me about 2 fps in Sly 4.
This has a bit more effect when disabling Atomic RSX FIFO although it's partially active without it.