Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sys_game_board_storage_read() #12769

Merged
merged 1 commit into from Oct 9, 2022
Merged

Update sys_game_board_storage_read() #12769

merged 1 commit into from Oct 9, 2022

Conversation

brian218
Copy link
Contributor

@brian218 brian218 commented Oct 7, 2022

So far, I have already discovered that there are 3 codes (0x40, 0xC0, and 0xF0), all of which expect exactly the same data.
As a result, I think it is appropriate to remove the switch-case conditions, as the algorithm seems to be generic for this syscall.

@elad335
Copy link
Contributor

elad335 commented Oct 7, 2022

Well I glanced at the disassembly of this syscall and this arg seems to be an out-pointer to 1 byte data. So it's not u8 it's vm::ptr<u8>. idk what it should output but yes it seems your guess is right.

@brian218
Copy link
Contributor Author

brian218 commented Oct 7, 2022

Well I glanced at the disassembly of this syscall and this arg seems to be an out-pointer to 1 byte data. So it's not u8 it's vm::ptr. idk what it should output but yes it seems your guess is right.

@elad335 I checked https://www.psdevwiki.com/ps3/LV2_Functions_and_Syscalls, it says the two params are "out:uint8_t[0x10], uint8_t[1]", and the output of current implementation does meet my game's expectation.

@elad335
Copy link
Contributor

elad335 commented Oct 7, 2022

It's fine it doesn't have to be implemented in this pr. And this wiki is edited by human beings it can have mistakes, I even corrected myself part of it in the past.

@Nekotekina Nekotekina merged commit d311b4b into RPCS3:master Oct 9, 2022
@brian218 brian218 deleted the patch-1 branch October 10, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants