Improved some sys_game syscalls #12787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suggest avoiding any write for now, but the type fix is easily approved. |
elad335
reviewed
Oct 10, 2022
brian218
changed the title
|
Also implemented sys_game_get_system_sw_version(), which represents the PS3 firmware version in an u64 form (firmware_version * 10000), e.g. 48900 for 4.89. Before this PR: After this PR: |
elad335
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected the implementation of sys_game_board_storage_read() according to @elad335's suggestion in #12769.
After doing some experiments, I came to the conclusion that the value of *buffer2 must be always set to 0x00 (regardless of the PSID, unlike *buffer1), otherwise the game will throw an error saying the check has failed.
Also implemented sys_game_get_system_sw_version(), which represents the PS3 firmware version in an u64 form (firmware_version * 10000), e.g. 48900 for 4.89.