Cubeb: rewrite locking #12805
Merged
Cubeb: rewrite locking #12805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 13, 2022
Megamouse
reviewed
Oct 13, 2022
elad335
reviewed
Oct 13, 2022
| @@ -427,14 +432,14 @@ long CubebBackend::data_cb(cubeb_stream* stream, void* user_ptr, void const* /* | |||
|
|
|||
| std::unique_lock lock(cubeb->m_cb_mutex, std::defer_lock); | |||
|
|
|||
| if (stream != cubeb->m_stream) | |||
| if (!cubeb->m_reset_req.observe() && lock.try_lock_for(std::chrono::microseconds{50}) && cubeb->m_write_callback && cubeb->m_playing) | |||
There was a problem hiding this comment.
Chancing a lock for a period of time needs to be well justified otherwise it looks like a workaround.
There was a problem hiding this comment.
It's typically taken by nonblocking code for a short period of time, so it makes sense to spin a bit.
Vestrel
force-pushed
the
audio_fixes
branch
2 times, most recently
from
d5a630d
to
885500b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12528 and maybe #12798