Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.cpp: fix dummy "Press.. START to resume" on crash #12906

Merged
merged 1 commit into from Nov 1, 2022

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Oct 30, 2022

It considered the pause state of a crash to be appropriate for this message. In reality holding the START button does nothing for it. btw there was a misconception that it is exclusive to savestates or something, well it affects all pause states.

@elad335 elad335 marked this pull request as draft October 30, 2022 16:37
@elad335
Copy link
Contributor Author

elad335 commented Oct 30, 2022

Actually it probably should signify the crash instead.

@elad335 elad335 marked this pull request as ready for review November 1, 2022 07:12
@elad335
Copy link
Contributor Author

elad335 commented Nov 1, 2022

Added a message reporting the crash.

Copy link
Contributor

@kd-11 kd-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Nekotekina Nekotekina merged commit 9632d0a into RPCS3:master Nov 1, 2022
@elad335 elad335 deleted the patch-6 branch November 1, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants