Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ux/core: Add module verification step for some critical libraries #13017

Merged
merged 6 commits into from Dec 6, 2022

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Dec 5, 2022

Prevents running the emu with downloaded dll files. Some more details are given on how to properly install a protected library and a link to the real download site provided.

Examples:
image

image

Fixes #6318

- Prevents running the emu with downloaded dll files
@kd-11 kd-11 requested a review from Megamouse December 5, 2022 21:23
rpcs3/module_verifier.hpp Outdated Show resolved Hide resolved
@RPCS3 RPCS3 deleted a comment from Juan12233 Dec 5, 2022
@kd-11
Copy link
Contributor Author

kd-11 commented Dec 6, 2022

Dropped the github link from dll verification notice.
image

rpcs3/main.cpp Outdated Show resolved Hide resolved
@Megamouse Megamouse merged commit 6155207 into RPCS3:master Dec 6, 2022
@strongui
Copy link

strongui commented Dec 7, 2022

This causes my instance to just error and fail to start. It shows missing vulkan error. Installing the exe from the link doesn't work. I'm not sure why it's even prompting me for vulkan I have a brand new sytem 3080ti. I reverted my rpcs3 version and everything works as normal.

@AniLeo
Copy link
Member

AniLeo commented Dec 7, 2022

The fix for this was already merged several hours ago

@kd-11 kd-11 deleted the dll_banlist branch December 7, 2022 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block RPCS3 from working when vulkan-1.dll is in RPCS3 folder
4 participants