Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread: silence -Wsign-compare on FreeBSD aarch64 #13257

Merged
merged 1 commit into from Jan 19, 2023
Merged

Thread: silence -Wsign-compare on FreeBSD aarch64 #13257

merged 1 commit into from Jan 19, 2023

Conversation

jbeich
Copy link
Contributor

@jbeich jbeich commented Jan 19, 2023

Error since #7524 which predates #11315 but around #11868 built fine by accident. From error log:

Utilities/Thread.cpp:1799:48: error: comparison of integers of different signs: 'uptr' (aka 'unsigned long') and '__register_t' (aka 'long') [-Werror,-Wsign-compare]
        const bool is_executing = uptr(info->si_addr) == RIP(context);
                                  ~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~
rpcs3/util/types.hpp
131:using uptr = std::uintptr_t;

/usr/include/machine/_types.h
75:typedef __int64_t       __register_t;
82:typedef __uint64_t      __uintptr_t;

/usr/include/machine/ucontext.h
40:     __register_t    gp_elr;

/usr/include/sys/signal.h
242:    void    *si_addr;               /* faulting instruction */

Note, ignore macOS CI:

Intel macOS instances are no longer supported!

b0ee533 built fine on macOS

Utilities/Thread.cpp:1805:48: error: comparison of integers of different signs: 'uptr' (aka 'unsigned long') and '__register_t' (aka 'long') [-Werror,-Wsign-compare]
        const bool is_executing = uptr(info->si_addr) == RIP(context);
                                  ~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~
@MSuih
Copy link
Member

MSuih commented Jan 19, 2023

We are trying to fix mac builds in #13155, just ignore the failures for now

@MSuih MSuih added OS: BSD Build and CI Anything related to the build process and continuous integration labels Jan 19, 2023
@Nekotekina Nekotekina merged commit 3eaa29e into RPCS3:master Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build and CI Anything related to the build process and continuous integration OS: BSD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants