Debugger: show CIA in register view #13462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
reviewed
Feb 27, 2023
rpcs3/Emu/Cell/PPUThread.cpp
Outdated
| @@ -1192,7 +1192,7 @@ void ppu_thread::dump_regs(std::string& ret) const | |||
| } | |||
| } | |||
|
|
|||
| fmt::append(ret, "CIA: 0x%08llx\n", cia); | |||
| fmt::append(ret, "CIA: 0x%08x\n", cia); | |||
There was a problem hiding this comment.
0x%07x suffices. It's rarely above 256mb.
There was a problem hiding this comment.
The always added 0 in logs looked odd there IMO. It's also how the debugger prints PPU instruction addresses now in which the added 0 looked odd there as well.
There was a problem hiding this comment.
Removed 0s prefix
ghost
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying CIA instead of typing it in is easier for later use