Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Array.h with std::vector #136

Closed
bagedevimo opened this issue Mar 29, 2014 · 3 comments · Fixed by #182
Closed

Replace Array.h with std::vector #136

bagedevimo opened this issue Mar 29, 2014 · 3 comments · Fixed by #182
Labels
Enhancement

Comments

@bagedevimo
Copy link
Contributor

Recommendation from Lioncash on IRC.
@bagedevimo
Copy link
Contributor Author

Includes some stack stuff, it seems

@bagedevimo
Copy link
Contributor Author

I don't mind doing this at some point

@Bigpet
Copy link
Contributor

Bigpet commented Mar 31, 2014

Gotta agree with that, there's so many little things that are sub-optimal about the Array class. For example the the Array::Move function takes a T* and calls free() on it, even though it's often being allocated with new.

@Bigpet Bigpet mentioned this issue Apr 12, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace Array with std::vector Bigpet/rpcs3
3 participants
@Bigpet @bagedevimo @AlexAltea