Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up ConLog, so it uses message passing to the main thread #137

Closed
bagedevimo opened this issue Mar 29, 2014 · 4 comments
Closed

Clean up ConLog, so it uses message passing to the main thread #137

bagedevimo opened this issue Mar 29, 2014 · 4 comments

Comments

@bagedevimo
Copy link
Contributor

Will give us cleaner code, and should drop the thread count by one. I'll try and do this some time in the next week or so.

This might be the cause of quite a few "random" segfaults on *nix.

@Bigpet
Copy link
Contributor

Bigpet commented Apr 7, 2014

Yeah, I kind of tried a few things (reading the buffer till it's empty in one event, only passing references to already converted wxStrings, etc.) and none gave me good performance under Windows.

The issue is that if we insist on writing every single log entry to the gui and then auto-sizing the columns with each addition it's never going to be as performant as we want.

The only thing that I could imagine actually helping is to decouple the gui data from the gui drawing. So we manage the log messages that are in the gui buffer as a data collection (i.e. vector or whatever the class was) and only refresh the gui at max rate of 60 or 30 fps. This means only showing the last few entries that fit into the the log window and then loading more from the data-buffer when the user is scrolling.

@NeilAvent
Copy link
Contributor

Would adding an option "log only to file" solve this? You could set that when wanting to have max performance and could use the log file rather than the GUI.

@Bigpet
Copy link
Contributor

Bigpet commented Apr 24, 2014

@Blaypeg that's already what happens when you tell it not to log anything

@Bigpet
Copy link
Contributor

Bigpet commented Jun 28, 2014

I'm guessing this is solved by #371

@Bigpet Bigpet closed this as completed Jun 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants