Loader: split add_only into own function #13760
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's better to have the boot and add stuff seperated, as it got really confusing over time and I realized there's not really much to it.
The new code does not require any modifications to the emulation state apart from loading and mounting parts of the VFS.
This also means less logging which confuses our discord bot.
I first copy pasted the loader code into a different file and started removing all the sections that are not affected by add_only.
Then I removed all the sections that were unreachable (unbeknownst to us).
And finally I reduced the remaining logic to simply log some notes instead of doing more analysis.
I'm sure some of the remaining code can be omited as well, but I am not confident to say what it's all about.