Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loader: split add_only into own function #13760

Merged
merged 2 commits into from Apr 28, 2023
Merged

Conversation

Megamouse
Copy link
Contributor

@Megamouse Megamouse commented Apr 25, 2023

  • Splits add_only code into own neat function that doesn't affect emulation
  • Fixes missing games from "/games" when refreshing the game list during gameplay

I think it's better to have the boot and add stuff seperated, as it got really confusing over time and I realized there's not really much to it.
The new code does not require any modifications to the emulation state apart from loading and mounting parts of the VFS.
This also means less logging which confuses our discord bot.

I first copy pasted the loader code into a different file and started removing all the sections that are not affected by add_only.
Then I removed all the sections that were unreachable (unbeknownst to us).
And finally I reduced the remaining logic to simply log some notes instead of doing more analysis.

I'm sure some of the remaining code can be omited as well, but I am not confident to say what it's all about.

@Megamouse Megamouse added GUI Loader Involving the load of PS3 file formats labels Apr 25, 2023
@Megamouse Megamouse force-pushed the add_only branch 19 times, most recently from f50e564 to 06e428b Compare April 26, 2023 21:43
@Megamouse Megamouse marked this pull request as ready for review April 26, 2023 21:45
@Megamouse Megamouse force-pushed the add_only branch 2 times, most recently from e6c71d4 to 30e69e9 Compare April 28, 2023 12:06
The new code does not require any modifications apart from loading vfs
There is no need to restrict this anymore
@Megamouse Megamouse merged commit 7bec3b3 into RPCS3:master Apr 28, 2023
4 of 5 checks passed
@Megamouse Megamouse deleted the add_only branch April 28, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix GUI Loader Involving the load of PS3 file formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant