PPU: Sleep after returning from thread entry function #13966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kd-11
previously approved these changes
Jun 6, 2023
|
I can confirm that this actually fixes an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested what happens if I let a thread return without calling sys_ppu_thread_exit, at first when a debugger was attached the process was paused.
But after detaching it the process would emit a thread dump but the other threads kept running!
This is what happens in #13274 which lets its thread do that and even relies on that, because just before the return of the entry function there is a store that releases the main PPU thread from a loop waiting for that byte to be set.
Fixes #13274.