Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vk: Improved OOM handling #13967

Merged
merged 3 commits into from Jun 9, 2023
Merged

vk: Improved OOM handling #13967

merged 3 commits into from Jun 9, 2023

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Jun 6, 2023 •
edited

  • Always release barrier references before destroying surfaces. In rare cases the surface may be detached without a collapse ever being triggered.

Fixes #13935

@kd-11
vk: Improved OOM handling
e525c77 
- Don't aggressively delete surfaces unless we're really crashing
- Release barrier resources before destroying the surface in case of fatal crash
@kd-11 kd-11 marked this pull request as draft June 6, 2023 14:03
@kd-11 kd-11 marked this pull request as ready for review June 9, 2023 22:37
@kd-11
Copy link
Contributor Author

kd-11 commented Jun 9, 2023

The reported issue is fixed by the PR, so I'll merge this as-is. The device-lost errors remain for some users, but that is separate work with multiple other issues already open.

@kd-11 kd-11 merged commit 27349c5 into RPCS3:master Jun 9, 2023
4 of 5 checks passed
@kd-11 kd-11 deleted the surface-cache-trim branch June 9, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Render: Vulkan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RSX error "Resource was destroyed whilst holding a resource reference" appears in logs
2 participants
@kd-11 @Megamouse