Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patches: Fix potential RPCS3 crashes due to invalid patches #14190

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Patches: Fix potential RPCS3 crashes due to invalid patches #14190

merged 1 commit into from
Jul 13, 2023

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Jul 12, 2023 •
edited

  • Stuff like writing u32 to 0xffffffff could have resulted in an RPCS3 crash due to size of patch not being taken intoi account when checking memory validity.
  • Add a new patch type called "cutf8" which is a null-terminated UTF8 string. (same semantics as std::string)
  • Fix alloc patch type recent regression and fix its behavior with PRX/SPU patches.

@elad335 elad335 force-pushed the patches branch 2 times, most recently from 8b034cf to d07685c Compare July 12, 2023 18:19
@Megamouse Megamouse added the Patches Patches and Mods label Jul 12, 2023
@elad335 elad335 force-pushed the patches branch 2 times, most recently from b2a36c4 to 7b20887 Compare July 12, 2023 18:27
@elad335 elad335 requested a review from Megamouse July 12, 2023 18:31
@elad335 elad335 force-pushed the patches branch 6 times, most recently from ac40bf5 to 937ff77 Compare July 12, 2023 19:01
@Megamouse
Copy link
Contributor

There's a function called patch_type_uses_hex_offset. Does it not need to include c_utf8 ?

@elad335 elad335 force-pushed the patches branch 2 times, most recently from 2ea4423 to 76d62b2 Compare July 13, 2023 04:23
@elad335 elad335 merged commit 083b4f0 into RPCS3:master Jul 13, 2023
4 of 5 checks passed
@elad335 elad335 deleted the patches branch May 6, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Megamouse Megamouse Awaiting requested review from Megamouse

Assignees
No one assigned
Labels
Patches Patches and Mods
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elad335 @Megamouse