Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge xfloat options #14247

Merged
merged 2 commits into from Aug 6, 2023
Merged

Merge xfloat options #14247

merged 2 commits into from Aug 6, 2023

Conversation

Megamouse
Copy link
Contributor

There doesn't seem to be a reason for three seperate options.

@Megamouse Megamouse added the Refactoring Refactors or simplifies existing code label Jul 23, 2023
@elad335
Copy link
Contributor

elad335 commented Jul 23, 2023

It makes the code cleaner and this breaks backwards compatibility.
Can't simply check if more than one setting is true and error if so?

@elad335 elad335 added the Caution: Breaks Backwards Compatibility Changes that breaks backwards compatibility label Jul 23, 2023
@Megamouse
Copy link
Contributor Author

This is a mess. There's no reason to keep this for backwards compatibility.
If we kept everything for this reason you would still have wx in this project.

@elad335
Copy link
Contributor

elad335 commented Jul 23, 2023

But then you have people confused why they suddenly lost 20 fps in their games.

@Megamouse
Copy link
Contributor Author

The whole reason for this is that people are confused by these options in the first place.

@Asinin3
Copy link
Contributor

Asinin3 commented Jul 23, 2023

This is good. We need to simplify the awful setting in the log. Breaking old configs for one setting that 99% of people didn't change isn't bad. Especially when its only going to fall back to approximate xfloat.. aka the safe option most people are already using.

Accurate XFloat is needed for a grand total of 3 games, see: https://wiki.rpcs3.net/index.php?title=Help:Configurations We also only suggest Relaxed xFloat for 8 games. Do other games work with Relaxed Xfloat and have a bit better perf? Yeah. But without them being tested/recommended on wiki, most people weren't using it already. Especially when we tell people to be wary of the option due to it causing issues in many games.

We are dropping Win7/8 with the upcoming qt6 change anyway, its as good of a time as any to make the change imo.

@readywer
Copy link

Gran Turismo 5 would be effected too, because accurate XFloat fixes audio for some of us. Maybe the best would be to move it under advenced/debug or at least just delet from the interface but leave it in the config file.

@Asinin3
Copy link
Contributor

Asinin3 commented Jul 23, 2023

@readywer No... Why would we hide the option that users need to change. Makes no sense. This PR isn't changing any of the options or removing anything. Its just simplofying the config.yml file because at the moment the way the xfloat accuracy setting works on the back-end is really old/incorrect. Its just a fix for that.

The only downside is it will reset the setting back to default.. but default is approximate. The accurate xfloat being needed for GT5 is only reported to be the case for like three people... And there's three other games that need it.. Making a big change for that is pointless.

@readywer
Copy link

Sorry i misunderstand the change than. But i don't think that i am the only one by looking at the dislikes.

@Megamouse Megamouse force-pushed the xfloat branch 2 times, most recently from 4260549 to a1799bf Compare July 31, 2023 17:48
@Megamouse Megamouse force-pushed the xfloat branch 2 times, most recently from 53c4ef4 to f3094a2 Compare August 2, 2023 22:45
@elad335 elad335 merged commit 343ba87 into RPCS3:master Aug 6, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Caution: Breaks Backwards Compatibility Changes that breaks backwards compatibility Refactoring Refactors or simplifies existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants