Optimize RSX Debugger #14397
Merged
Optimize RSX Debugger #14397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
force-pushed
the
plain
branch
2 times, most recently
from
3ecb030
to
11ceb06
Compare
Megamouse
reviewed
Jul 31, 2023
elad335
force-pushed
the
plain
branch
5 times, most recently
from
0252db6
to
d1d8555
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each
rsx::thread::dump_regs()call, thousands of strings were allocated and copied. This resulted in the debugger being sluggish.This is changed with this pr which replaces the copies and allocations with appending to one unified string result.