Progress Dialog: Fix race on PPU compilation status #14526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
reviewed
Aug 21, 2023
rpcs3/Emu/Cell/PPUThread.cpp
Outdated
| @@ -4523,10 +4523,13 @@ bool ppu_initialize(const ppu_module& info, bool check_only) | |||
| // Check object file | |||
| if (jit_compiler::check(cache_path + obj_name)) | |||
| { | |||
| if (!jit && !check_only) | |||
There was a problem hiding this comment.
It was a bug, g_progr_ptotal is incremented if check_only is false. It does not care about null jit.
There was a problem hiding this comment.
Actually, this change is wrong.
It's incremented later again if it needs to be compiled a couple of lines below.
So you're incrementing the uncached ones twice now.
elad335
force-pushed
the
bless
branch
6 times, most recently
from
84f6d14
to
32e0a24
Compare
Megamouse
reviewed
Aug 21, 2023
Megamouse
reviewed
Aug 21, 2023
Megamouse
reviewed
Aug 21, 2023
Megamouse
reviewed
Aug 21, 2023
elad335
force-pushed
the
bless
branch
3 times, most recently
from
0e32ddf
to
8b86fad
Compare
|
lgtm. But I haven't tested anything. |
|
Sadly it's broken AF xD |
elad335
force-pushed
the
bless
branch
4 times, most recently
from
5b42e96
to
3540b45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If more than one PPU thread was loading PPU PRX/OVL, there could have been a race that would make the "Compiling PPU Modules" message never disappear because one thread was storing the string the other thread stored. (g_progr never gets null again)