PPU Analyzer/Savestates: Usability improvements, Reduce LLVM compilation of garbage data

[elad335]

Previously, savestates 99% of the time caused a second, and much longer (!) PPU LLVM compilation in addition to the already existing cache because it is scanning the whole segment 0. This was done in order to support analysis of patches applied within the savestate file on instructions located outside of registered code regions in executable.
Now, why savestates do not simply allow patches to be reused and re-register them instead? because applying patches after boot (on savestates for example) and before boot (normal patches) is not the same operation and may have different and unexpected consequences on farther execution.

The idea here is simply to avoid this and compile segment 0 at all times, so there won't be a second compilation for savestates. In order to avoid compiling garbage data, I added some more constraints in PPU Analayzer.

Please test if PPU LLVM compilation is being signficantly prolonged by this pr and remove previous PPU cache before testing.
I improved constrainsts further and made the "anti-optimization" affect only when patches are applied.
So in turn it may actually improve PPU LLVM compilation time when patches are not applied.

[cipherxof]

Pretty much no difference compiling MGS4 (without PPU precompilation). 27.4s (master) vs 27.9s (pr)

[elad335]

I improved constrainsts further and made it affect only when patches are applied.

[Ordinary205]

Causes fatal error if I try to boot up the emulator.

RPCS3.log.gz

[elad335]

Fixed.

[Ordinary205]

And it just hangs there after building the SPU caches.
Had to use Task Manager to shut down the emulator, due to a deadlock issue.

RPCS3.log.gz

[elad335]

And it just hangs there after building the SPU caches. Had to use Task Manager to shut down the emulator, due to a deadlock issue. RPCS3.log.gz

·F 0:02:20.221796 {PPU[0x1000008] Thread ([MC] Render Thread) [0x00512a60]} SIG: Thread terminated due to fatal error: Assertion Failed! Vulkan API call failed with unrecoverable error: Device lost (Driver crashed with unspecified error or stopped responding and recovered) (VK_ERROR_DEVICE_LOST)
(in file C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\rpcs3\Emu\RSX\VK\vkutils\sync.cpp:610[:5], in function wait_for_event)
(in file C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\rpcs3\Emu\RSX\VK\vkutils\shared.cpp:114[:24], in function die_with_error)

Vulkan crash seems unrelated, maybe try again.

[Ordinary205]

Oh sorry I didn't realized that I had VK_ERROR_DEVICE_LOST.
But yes it does boot up correctly after retesting.

RPCS3.log.gz

[elad335]

You can open an issue if you catch it again.