Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPU LLVM: Re-add multi-threaded (multi-files) overlay module compilation #14635

Merged
merged 7 commits into from
Sep 10, 2023

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Sep 9, 2023

Fixes #9694

Should improve MGS4 compilation time.

Fixed a regression from #14622.

@elad335 elad335 added Enhancement LLVM Related to LLVM instruction decoders labels Sep 9, 2023
@elad335 elad335 changed the title PPU LLVM: Re-add multi-threaded overlay module compilation PPU LLVM: Re-add multi-threaded (multi-files) overlay module compilation Sep 9, 2023
@Ordinary205
Copy link
Contributor

Demon's Souls crashes while loading PPU Modules.
PPU thread bug
RPCS3.log.gz

@Ordinary205
Copy link
Contributor

Same error, nothing changes.
RPCS3.log.gz

@elad335
Copy link
Contributor Author

elad335 commented Sep 9, 2023

Maybe fixed now.

@Ordinary205
Copy link
Contributor

Demon's Souls now boots properly.
Demons Souls works
RPCS3.log.gz

/rpcs3/rpcs3/Emu/Cell/../Memory/vm_ptr.h:135:32: warning: invalid application of 'sizeof' to a void type [-Wpointer-arith]
  135 |                         return sizeof(T);
      |                                ^~~~~~~~~
@elad335
Copy link
Contributor Author

elad335 commented Sep 10, 2023

Will merge, testers can test later MGS4 compilation time. For me it is 100% CPU usage. It also contains a hotfix.

@elad335 elad335 added the Bugfix label Sep 10, 2023
@elad335 elad335 merged commit 37ba197 into RPCS3:master Sep 10, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Enhancement LLVM Related to LLVM instruction decoders
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Multithreaded (multi-files) overlay modules precompilation
2 participants