Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rsx: Detiler improvements #14706

Merged
merged 3 commits into from Oct 12, 2023
Merged

rsx: Detiler improvements #14706

merged 3 commits into from Oct 12, 2023

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Oct 4, 2023

This PR handles 2 corner cases:

  1. On 'DMA' sections, tiling breaks pitch calculations because the bpp is 0.
  2. When doing blit transfer, we may copy out of a tiled area to a non-tiled area. Tiling on read via blit src path is now handled.

No idea if this fixes any games.

@kd-11
rsx: Detiler improvements
454811b 
- Detile on blit src read
- Improve blit engine integration
@kd-11 kd-11 mentioned this pull request Oct 4, 2023
Open
8 tasks
@Megamouse Megamouse added the RSX label Oct 4, 2023
@Ordinary205
Copy link
Contributor

Ordinary205 commented Oct 4, 2023 •
edited

This PR does fixes regression on NFS The Run, but sadly Battlefield 3 is still affected.
Battlefield 3 still regression
RPCS3.log.gz

@Ordinary205
Copy link
Contributor

Same thing with Rivals.
NFS Rivals
Appearently this PR allows other frostbite games to appear 3D graphics instead of 2D, but still looks corrupted.
RPCS3.log.gz

@TigiHof
Copy link

TigiHof commented Oct 4, 2023

Artifact still present in Star Wars: The Force Unleashed

NPEB90094_screenshot_2023_10_04_17_14_16

@kd-11 kd-11 marked this pull request as ready for review October 8, 2023 13:23
@kd-11 kd-11 merged commit e95cff0 into RPCS3:master Oct 12, 2023
5 checks passed
@kd-11 kd-11 deleted the rsx-tiling branch October 12, 2023 12:25
@Ordinary205
Copy link
Contributor

This PR no longer fixes NFS The Run, and Battlefield 3 now looks like this.
Battlefield 3
RPCS3.log.gz

@kd-11
Copy link
Contributor Author

kd-11 commented Oct 12, 2023

It's fine if it doesn't fix the games, it achieves the goal to tie up some loose ends in the code. As long as nothing regressed, it's good.
Now that it is merged, discussions should only happen in #14682

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
RSX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kd-11 @Ordinary205 @TigiHof @Megamouse