[UI/UX] Fix Firmware tree checkboxes for Darker Style by TheMitoSan file #14799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it look like the rest of the file to communicate with the user correctly
|
@Megamouse It looked odd on the preview, missing space between the text and checkbox so I didn't merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
This isn't my custom stylesheet and may get taken over by a different pull request. But keynotes to look for.
The box being filled in with white is ticked throughout the entire theme until it comes to the firmware tree.
So I added QListWidget and QTreeWIdget names to the checkboxes section so as not to mess with any of the colors, borders, margins, padding, or anything else. This enables clear communication to the user what is ticked, unticked, enabled, disabled or anything else by simply keeping a uniform interface for the user to interact with and not just changing the rules when it comes to a specific group/location of the interface.
I notice the checkbox size appears a little big in the after vs before among many other modernizations I'd love to change. Yet this isn't my stylesheet. And I do believe this PR will be edited by maintainers or overruled.