Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement audio recording #14817

Merged
merged 20 commits into from Nov 23, 2023
Merged

Implement audio recording #14817

merged 20 commits into from Nov 23, 2023

Conversation

Megamouse
Copy link
Contributor

@Megamouse Megamouse commented Nov 13, 2023

Recording in general

  • Adds an audio track to video recording (currently AC3 as proof of concept)
  • The channel count matches the game's output channel count
  • The recording expects 256 samples per block at 48000 samples per second
  • We drop packages that are too early (should not really happen with regular recording)
  • We add silence if we get packages too late in order to make the encoder happy and don't get desync.

cellRec

  • Implements most features of cellRec audio encoding
  • This includes internal cellAudio sources as well as external cellRec sources (external is untested)
  • Always downmix to stereo, since cellRec only does 2 channels.
  • Adds the external cellRec audio to the internal cellAudio with a volume factor
  • Works with both the ringbuffer recording as well as the regular recording

Known issues

  • Recorded audio may have crackling if the recording is paused and resumed.

implements #11874

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant