split JIT.cpp and SPURecompiler.cpp #14973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
reviewed
Dec 30, 2023
oltolm
force-pushed
the
split
branch
2 times, most recently
from
ea31b7d
to
53d888f
Compare
Megamouse
reviewed
Jan 2, 2024
Megamouse
reviewed
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I split those two files into an LLVM and a non-LLVM parts.
SPURecompiler.cpphas 12400 lines andJIT.cpp1500 lines.SPURecompiler.cppis so big that clangd has trouble working and I have a fast CPU. I made sure to keep the git history. Maybe it's not worth splittingJIT.cppbecause it's not that big. I could revert it.