Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve re_accurate #15201

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Improve re_accurate #15201

merged 2 commits into from
Feb 13, 2024

Conversation

RipleyTom
Copy link
Contributor

@RipleyTom RipleyTom commented Feb 12, 2024

  • After some testing the full sequence on real ps3 it seems that frest => fi => fnms => fma sequence will differ from 1/x in 2 ways:
    Infinite on x86 becomes NaN(with sign respected) on ps3
    NaN on x86 becomes Zero(with no sign) on ps3
    Fixed the code to reflect it.
  • Added the 'one' value as a parameter to the intrinsic(might make it easier to add intrinsic for other special values if any is found.)
  • fixed 2 messed up patterns(checked a for both fnms and frest, oops).
  • Removed 2 useless if checks that predates the xfloat merging PR from ages ago.
  • on re_accurate, erased all the stores(might lead to some regressions, I tried a bunch of games and they all seemed fine).
  • Fixed full fm(a, re_accurate) pattern with the same pattern as 1/x(as 0 * value => 0 and nan * value => nan).
  • Since that fixes Resistance 2 bug with this pattern, put it back into approximate.

Fixes #15186

@elad335 elad335 merged commit 50b1402 into RPCS3:master Feb 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression] Misoriented effects with Xfloat Approximate in Ratchet & Clank: Into the Nexus after #13897
3 participants