Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overlays: use signed short for position to allow negative positions #15204

Merged
merged 1 commit into from Feb 13, 2024
Merged

overlays: use signed short for position to allow negative positions #15204

merged 1 commit into from Feb 13, 2024

Conversation

Megamouse
Copy link
Contributor

  • Fixes positioning an overlay to the top and/or left of the screen. This would previously overflow and disappear
  • This fixes the mouse/move pointer disappearing partially or completely when it's near to the left or upper border

This was previously invisible at that location:
image

@Megamouse Megamouse requested a review from kd-11 February 13, 2024 19:31
@Megamouse Megamouse force-pushed the signed_coords branch 2 times, most recently from 3a5e454 to d199e5f Compare February 13, 2024 19:35
kd-11
kd-11 approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@kd-11 kd-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the right way to do it. Signed position, unsigned dimensions.

@Megamouse Megamouse merged commit f6f8996 into RPCS3:master Feb 13, 2024
4 of 6 checks passed
@Megamouse Megamouse deleted the signed_coords branch February 13, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kd-11 kd-11 kd-11 approved these changes

Assignees
No one assigned
Labels
Overlay
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Megamouse @kd-11